-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added capability to set the rsyslog container resources #1410
Conversation
@rakesh561 CI is complaining about some trailing whitespace. Do you mind fixing that in your PR? There also seems to be some sort of syntax issue in the AWX CRD based on this error:
|
1 similar comment
@rakesh561 CI is complaining about some trailing whitespace. Do you mind fixing that in your PR? There also seems to be some sort of syntax issue in the AWX CRD based on this error:
|
@rooftopcellist will do thanks for the quick review |
@rakesh561 CI is complaining about some trailing whitespace. Do you mind fixing that in your PR? There also seems to be some sort of syntax issue in the AWX CRD based on this error:
It looks like there are two indentation errors that need to be fixed before this will work. Once those are fixed, I will happily merge this. Thanks! |
Thanks for putting this all together @rakesh561 ! |
Hello, so it overwrites the existing config, and the rsyslog container starts without the configured limits. Please check this |
SUMMARY
This commit allows users to set requests and limits on rsyslog containers and address issue #1380
ISSUE TYPE